From cbfe54c5609584c9c895262df6a7a58d675473ba Mon Sep 17 00:00:00 2001 From: nobu Date: Tue, 1 Nov 2016 12:35:32 +0000 Subject: [PATCH] numeric.c: fix return value on big 0 * numeric.c (num_zero_p): should return true if zero. rb_bigzero_p returns 1 or 0. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56538 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- numeric.c | 5 ++++- test/-ext-/bignum/test_bigzero.rb | 6 ++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/numeric.c b/numeric.c index 21e8eeeb8e..9a9b8d0b44 100644 --- a/numeric.c +++ b/numeric.c @@ -721,7 +721,10 @@ num_zero_p(VALUE num) } } else if (RB_TYPE_P(num, T_BIGNUM)) { - return rb_bigzero_p(num); + if (rb_bigzero_p(num)) { + /* this should not happen usually */ + return Qtrue; + } } else if (rb_equal(num, INT2FIX(0))) { return Qtrue; diff --git a/test/-ext-/bignum/test_bigzero.rb b/test/-ext-/bignum/test_bigzero.rb index 8529e54456..43a99b01a3 100644 --- a/test/-ext-/bignum/test_bigzero.rb +++ b/test/-ext-/bignum/test_bigzero.rb @@ -10,5 +10,11 @@ class TestBignum < Test::Unit::TestCase assert_equal(0, Bug::Bignum.zero(i), "#{bug8204} Bignum.zero(#{i})") end end + + def test_zero? + (0..10).each do |i| + assert_equal(true, Bug::Bignum.zero(i).zero?) + end + end end end