From cb92817e7cb41f31abf371dc162996554ab50f6a Mon Sep 17 00:00:00 2001 From: kosaki Date: Fri, 14 Dec 2012 15:11:59 +0000 Subject: [PATCH] * signal.c (rb_f_kill): remove rb_thread_polling() because this has no good effect and makes meaningless 100ms delay. 1) when sending signal to another process, waiting has just silly. 2) when sending signal to current process, 100ms is often not enough time to wait. It depend on kernel behavior. And, rb_thread_polling() doesn't make sense anyway. When rb_thread_alone() is true, it doesn't wait at all and Process.kill() users don't expect threading changes Process.kill() behavior. [Bug #7560] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@38380 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 11 +++++++++++ signal.c | 1 - 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index b4f4fe47b3..c4126756e0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,14 @@ +Sat Dec 15 00:03:31 2012 KOSAKI Motohiro + + * signal.c (rb_f_kill): remove rb_thread_polling() because this + has no good effect and makes meaningless 100ms delay. 1) + when sending signal to another process, waiting has just silly. + 2) when sending signal to current process, 100ms is often not + enough time to wait. It depend on kernel behavior. And, + rb_thread_polling() doesn't make sense anyway. When rb_thread_alone() + is true, it doesn't wait at all and Process.kill() users don't + expect threading changes Process.kill() behavior. [Bug #7560] + Fri Dec 14 17:10:57 2012 Nobuyoshi Nakada * parse.y (parser_params): parser_tokline to track the line number at diff --git a/signal.c b/signal.c index 0d41fada5a..59ffde93db 100644 --- a/signal.c +++ b/signal.c @@ -425,7 +425,6 @@ rb_f_kill(int argc, VALUE *argv) rb_sys_fail(0); } } - rb_thread_polling(); return INT2FIX(i-1); }