From c9b6a01435ef814f790f770520400e7f6ccc5e20 Mon Sep 17 00:00:00 2001 From: nobu Date: Fri, 16 Nov 2012 07:28:30 +0000 Subject: [PATCH] range.c: compare signedness only * range.c (BSEARCH_CHECK): compare signedness only and relax an assumption of the result of rb_cmpint() which compilers cannot know. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37676 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- range.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/range.c b/range.c index b5cdc9e442..4c2252f1b3 100644 --- a/range.c +++ b/range.c @@ -543,11 +543,9 @@ range_bsearch(VALUE range) smaller = 0; \ } \ else if (rb_obj_is_kind_of(v, rb_cNumeric)) { \ - switch (rb_cmpint(rb_funcall(v, id_cmp, 1, INT2FIX(0)), v, INT2FIX(0))) { \ - case 0: return val; \ - case -1: smaller = 1; break; \ - case 1: smaller = 0; \ - } \ + int cmp = rb_cmpint(rb_funcall(v, id_cmp, 1, INT2FIX(0)), v, INT2FIX(0)); \ + if (!cmp) return val; \ + smaller = cmp < 0; \ } \ else { \ smaller = RTEST(v); \