1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "Warn it only with -W:deprecated"

Browse Source 
This reverts commit 5458252bb0edcd498e6bd4bea57fd7500bacd54c.

Revert "Fallback rb_warn_deprecated for UNIVERSAL_PARSER"

This reverts commit 680be886f4d807073f24beed36648ef76219e4f7.

matz actually preferred always warning `it`.
This commit is contained in:
Takashi Kokubun 2023-12-07 00:02:52 -08:00
parent 680be886f4
commit c6eb355e04
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
parse.y
View File

@ -44,8 +44,6 @@
#define rb_str_coderange_scan_restartable p->config->str_coderange_scan_restartable
#endif
#define rb_warn_deprecated(fmt, suggest) rb_warn0(fmt " is deprecated; use " suggest " instead")
#else
#include "internal.h"
@ -12790,7 +12788,7 @@ gettable(struct parser_params *p, ID id, const YYLTYPE *loc)
if (dyna_in_block(p) && id == rb_intern("it")
&& !(DVARS_TERMINAL_P(p->lvtbl->args) || DVARS_TERMINAL_P(p->lvtbl->args->prev))
&& p->max_numparam != ORDINAL_PARAM) {
rb_warn_deprecated("calling `it` without arguments in a block", "it() or self.it");
rb_warn0("`it` calls without arguments will refer to the first block param in Ruby 3.4; use it() or self.it");
}
return NEW_VCALL(id, loc);
case ID_GLOBAL: