1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Bug #19901]

Browse Source 
fix leak in module clone

Co-authored-by: Peter Zhu <peter@peterzhu.ca>
This commit is contained in:
Adam Hess 2023-09-23 19:41:55 +00:00 committed by Jean Boussier
parent 61a2e9450c
commit c42261059d
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
class.c
View File

@ -471,6 +471,7 @@ copy_tables(VALUE clone, VALUE orig)
rb_id_table_foreach(rb_cvc_tbl, cvc_table_copy, &ctx); rb_id_table_foreach(rb_cvc_tbl, cvc_table_copy, &ctx);
RCLASS_CVC_TBL(clone) = rb_cvc_tbl_dup; RCLASS_CVC_TBL(clone) = rb_cvc_tbl_dup;
} }
rb_id_table_free(RCLASS_M_TBL(clone));
RCLASS_M_TBL(clone) = 0; RCLASS_M_TBL(clone) = 0;
if (!RB_TYPE_P(clone, T_ICLASS)) { if (!RB_TYPE_P(clone, T_ICLASS)) {
st_data_t id; st_data_t id;

12
test/ruby/test_module.rb
View File

@ -3321,6 +3321,18 @@ class TestModule < Test::Unit::TestCase
CODE CODE
end end
def test_module_clone_memory_leak
# [Bug #19901]
assert_no_memory_leak([], <<~PREP, <<~CODE, rss: true)
code = proc do
Module.new.clone
end
1_000.times(&code)
PREP
1_000_000.times(&code)
CODE
end
private private
def assert_top_method_is_private(method) def assert_top_method_is_private(method)