1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't include bad password in URI exception output

Browse Source 
We shouldn't include the bad password in the URI exception output
message.  Just knowing that there is a bad password is enough
information.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56166 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
tenderlove 2016-09-15 21:44:56 +00:00
parent 7070c5bff3
commit c2cbd5528c
3 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ChangeLog
View File

@ -1,3 +1,10 @@
Fri Sep 16 06:43:25 2016 Aaron Patterson <tenderlove@ruby-lang.org>
* lib/uri/generic.rb (def check_password): don't include bad password
in URI exception output
* test/uri/test_generic.rb (def test_set_component): test for behavior
Thu Sep 15 21:40:03 2016 Kazuhiro NISHIYAMA <zn@mbf.nifty.com> Thu Sep 15 21:40:03 2016 Kazuhiro NISHIYAMA <zn@mbf.nifty.com>
* doc/extension.ja.rdoc: Fix file name. * doc/extension.ja.rdoc: Fix file name.

2
lib/uri/generic.rb
View File

@ -428,7 +428,7 @@ module URI
if parser.regexp[:USERINFO] !~ v if parser.regexp[:USERINFO] !~ v
raise InvalidComponentError, raise InvalidComponentError,
"bad component(expected user component): #{v}" "bad password component"
end end
return true return true

9
test/uri/test_generic.rb
View File

@ -749,6 +749,15 @@ class URI::TestGeneric < Test::Unit::TestCase
assert_equal('foo:xyzzy', uri.to_s) assert_equal('foo:xyzzy', uri.to_s)
end end
def test_bad_password_component
uri = URI.parse('http://foo:bar@baz')
password = 'foo@bar'
e = assert_raise(URI::InvalidComponentError) do
uri.password = password
end
refute_match password, e.message
end
def test_set_scheme def test_set_scheme
uri = URI.parse 'HTTP://example' uri = URI.parse 'HTTP://example'