1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve Time#+ & Time#- performance

Browse Source 
* time.c (wadd): use internal addv() function to calculate internal value in
    Time object. On 64-bit machine, Time object might have Fixnum object
    internally by default and addv() can calculate Fixnum objects directly.

* time.c (wsub): use internal subv() function due the same reason in above.

    Time#+ & Time#- will be faster around 15%.

    [ruby-dev:50036] [Bug #13357] [Fix GH-1547]

### Before
             user     system      total        real
Time#+   0.820000   0.000000   0.820000 (  0.818081)
Time#-   0.810000   0.000000   0.810000 (  0.813835)

### After
             user     system      total        real
Time#+   0.710000   0.000000   0.710000 (  0.710241)
Time#-   0.710000   0.010000   0.720000 (  0.714151)

### Test code
require 'benchmark'

Benchmark.bmbm do |x|

  x.report "Time#+" do
    t = Time.now
    2000000.times do
      t + 1
    end
  end

  x.report "Time#-" do
    t = Time.now
    2000000.times do
      t - 1
    end
  end

end

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58829 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
watson1978 2017-05-21 03:36:31 +00:00
parent 92ea637c62
commit c208d15ff7
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
time.c
View File

@ -345,33 +345,25 @@ wcmp(wideval_t wx, wideval_t wy)
static wideval_t static wideval_t
wadd(wideval_t wx, wideval_t wy) wadd(wideval_t wx, wideval_t wy)
{ {
VALUE x;
#if WIDEVALUE_IS_WIDER #if WIDEVALUE_IS_WIDER
if (FIXWV_P(wx) && FIXWV_P(wy)) { if (FIXWV_P(wx) && FIXWV_P(wy)) {
wideint_t r = FIXWV2WINT(wx) + FIXWV2WINT(wy); wideint_t r = FIXWV2WINT(wx) + FIXWV2WINT(wy);
return WINT2WV(r); return WINT2WV(r);
} }
else
#endif #endif
x = w2v(wx); return v2w(addv(w2v(wx), w2v(wy)));
if (RB_TYPE_P(x, T_BIGNUM)) return v2w(rb_big_plus(x, w2v(wy)));
return v2w(rb_funcall(x, '+', 1, w2v(wy)));
} }
static wideval_t static wideval_t
wsub(wideval_t wx, wideval_t wy) wsub(wideval_t wx, wideval_t wy)
{ {
VALUE x;
#if WIDEVALUE_IS_WIDER #if WIDEVALUE_IS_WIDER
if (FIXWV_P(wx) && FIXWV_P(wy)) { if (FIXWV_P(wx) && FIXWV_P(wy)) {
wideint_t r = FIXWV2WINT(wx) - FIXWV2WINT(wy); wideint_t r = FIXWV2WINT(wx) - FIXWV2WINT(wy);
return WINT2WV(r); return WINT2WV(r);
} }
else
#endif #endif
x = w2v(wx); return v2w(subv(w2v(wx), w2v(wy)));
if (RB_TYPE_P(x, T_BIGNUM)) return v2w(rb_big_minus(x, w2v(wy)));
return v2w(rb_funcall(x, '-', 1, w2v(wy)));
} }
static wideval_t static wideval_t