From c173c637ab7e971a5b6c56deabe9e1a7c95667fb Mon Sep 17 00:00:00 2001 From: Stan Lo Date: Fri, 11 Aug 2023 19:27:12 +0100 Subject: [PATCH] [ruby/irb] Skip integration tests in core CI (https://github.com/ruby/irb/pull/677) We already skipped history integration tests in core CI in #675 due to suspicion on nested IRB sessions don't work on certain operating systems. But after #669, the evaluation integration test also started to fail on some Core CI suites. So, it looks like the integration test setup may not work in Core CI, at least in some suites. Consider `ruby/irb` already has rather sophisticated test suite, I think it's better to skip the integration tests in core CI for now. https://github.com/ruby/irb/commit/6f49b4c108 --- test/irb/helper.rb | 4 ++++ test/irb/test_debug_cmd.rb | 4 ---- test/irb/test_history.rb | 8 -------- 3 files changed, 4 insertions(+), 12 deletions(-) diff --git a/test/irb/helper.rb b/test/irb/helper.rb index bbdb16eed0..e281b8e2f6 100644 --- a/test/irb/helper.rb +++ b/test/irb/helper.rb @@ -87,6 +87,10 @@ module TestIRB omit "Integration tests require PTY." end + if ruby_core? + omit "This test works only under ruby/irb" + end + @envs = {} end diff --git a/test/irb/test_debug_cmd.rb b/test/irb/test_debug_cmd.rb index d4cd87c750..35239364ba 100644 --- a/test/irb/test_debug_cmd.rb +++ b/test/irb/test_debug_cmd.rb @@ -10,10 +10,6 @@ module TestIRB def setup super - if ruby_core? - omit "This test works only under ruby/irb" - end - if RUBY_ENGINE == 'truffleruby' omit "This test runs with ruby/debug, which doesn't work with truffleruby" end diff --git a/test/irb/test_history.rb b/test/irb/test_history.rb index 489ae2f3af..39f9e82750 100644 --- a/test/irb/test_history.rb +++ b/test/irb/test_history.rb @@ -210,14 +210,6 @@ module TestIRB end class NestedIRBHistoryTest < IntegrationTestCase - def setup - super - - if ruby_core? - omit "This test works only under ruby/irb" - end - end - def test_history_saving_with_nested_sessions write_history ""