1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

flo_to_s: do not goto into a branch

Browse Source 
I'm not necessarily against every goto in general, but jumping into a
branch is definitely a bad idea.  Better refactor.
This commit is contained in:
卜部昌平 2020-06-16 09:42:18 +09:00
parent 41703fcfab
commit bf19820bb3
Notes: git 2020-06-29 11:06:59 +09:00 
Merged: https://github.com/ruby/ruby/pull/3247
1 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
numeric.c
View File

@ -985,19 +985,22 @@ flo_to_s(VALUE flt)
memcpy(ptr -= decpt, buf, digs); memcpy(ptr -= decpt, buf, digs);
} }
else { else {
exp: goto exp;
if (digs > 1) {
memmove(buf + 2, buf + 1, digs - 1);
}
else {
buf[2] = '0';
digs++;
}
buf[1] = '.';
rb_str_cat(s, buf, digs + 1);
rb_str_catf(s, "e%+03d", decpt - 1);
} }
return s; return s;
exp:
if (digs > 1) {
memmove(buf + 2, buf + 1, digs - 1);
}
else {
buf[2] = '0';
digs++;
}
buf[1] = '.';
rb_str_cat(s, buf, digs + 1);
rb_str_catf(s, "e%+03d", decpt - 1);
return s;
} }
/* /*