Revert "[rubygems/rubygems] Set thread configurations inside block"

This reverts commit db80e947a382a6a9ef2295e81f5b97c6a8ecbce7.

This patch uses `Thread.abort_on_exception = true` and it affects
all of threads. This is why CI systems fails.

How to modify:

- use `thread.abort_on_exception = true` for specific threads
- Run this code in a separated process
This commit is contained in:
ko1 2023-07-29 07:28:52 +09:00
parent 17b50cdb68
commit bcf823fddb
2 changed files with 4 additions and 4 deletions

View File

@ -34,14 +34,14 @@ module Gem::GemcutterUtilities
def self.listener_thread(host, server)
thread = Thread.new do
Thread.abort_on_exception = true
Thread.report_on_exception = false
Thread.current[:otp] = new(host).wait_for_otp_code(server)
rescue Gem::WebauthnVerificationError => e
Thread.current[:error] = e
ensure
server.close
end
thread.abort_on_exception = true
thread.report_on_exception = false
thread
end

View File

@ -33,12 +33,12 @@ module Gem::GemcutterUtilities
def self.poll_thread(options, host, webauthn_url, credentials)
thread = Thread.new do
Thread.abort_on_exception = true
Thread.report_on_exception = false
Thread.current[:otp] = new(options, host).poll_for_otp(webauthn_url, credentials)
rescue Gem::WebauthnVerificationError, Timeout::Error => e
Thread.current[:error] = e
end
thread.abort_on_exception = true
thread.report_on_exception = false
thread
end