1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Only set shape id for CCs on attr_set + ivar

Browse Source 
Only ivar reader and writer methods should need the shape ID set on the
inline cache.  We shouldn't accidentally overwrite parts of the CC union
when it's not necessary.
This commit is contained in:
Aaron Patterson 2024-06-06 17:38:25 -07:00 committed by Aaron Patterson
parent 16b0242808
commit bbeebc9258
Notes: git 2024-07-31 23:23:45 +00:00 
Merged: https://github.com/ruby/ruby/pull/11291
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
vm_callinfo.h
View File

@ -348,7 +348,10 @@ vm_cc_new(VALUE klass,
break;
}
vm_cc_attr_index_initialize(cc, INVALID_SHAPE_ID);
if (cme->def->type == VM_METHOD_TYPE_ATTRSET || cme->def->type == VM_METHOD_TYPE_IVAR) {
vm_cc_attr_index_initialize(cc, INVALID_SHAPE_ID);
}
RB_DEBUG_COUNTER_INC(cc_new);
return cc;
}