1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ruby/prism] Refactor pm_node_list_insert to use a binary search

Browse Source 
https://github.com/ruby/prism/commit/a060b21e1d
This commit is contained in:
Kevin Newton 2024-02-23 11:44:19 -05:00
parent a38cc177d2
commit b9202788f8
1 changed files with 17 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
prism/static_literals.c
View File

@ -6,26 +6,32 @@
*/ */
static pm_node_t * static pm_node_t *
pm_node_list_insert(const pm_parser_t *parser, pm_node_list_t *list, pm_node_t *node, int (*compare)(const pm_parser_t *parser, const pm_node_t *left, const pm_node_t *right)) { pm_node_list_insert(const pm_parser_t *parser, pm_node_list_t *list, pm_node_t *node, int (*compare)(const pm_parser_t *parser, const pm_node_t *left, const pm_node_t *right)) {
// TODO: This would be much more efficient with a binary search. size_t low = 0;
size_t index = 0; size_t high = list->size;
while (index < list->size) {
int result = compare(parser, list->nodes[index], node);
// If we find a match, then replace the node and return the old one. while (low < high) {
size_t mid = (low + high) / 2;
int result = compare(parser, list->nodes[mid], node);
// If we find a match, then replace the old node with the new one and
// return the old one.
if (result == 0) { if (result == 0) {
pm_node_t *result = list->nodes[index]; pm_node_t *result = list->nodes[mid];
list->nodes[index] = node; list->nodes[mid] = node;
return result; return result;
} }
if (result > 0) break; if (result < 0) {
index++; low = mid + 1;
} else {
high = mid;
}
} }
pm_node_list_grow(list); pm_node_list_grow(list);
memmove(&list->nodes[index + 1], &list->nodes[index], (list->size - index) * sizeof(pm_node_t *)); memmove(&list->nodes[low + 1], &list->nodes[low], (list->size - low) * sizeof(pm_node_t *));
list->nodes[index] = node; list->nodes[low] = node;
list->size++; list->size++;
return NULL; return NULL;