1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ruby/prism] Do not warn for unused variables on negative lines

Browse Source 
Fixes [Bug #20788]

https://github.com/ruby/prism/commit/27e91f21af
This commit is contained in:
Kevin Newton 2024-10-10 10:57:05 -04:00 committed by git
parent d12c8cbf14
commit b5ecb03ae4
2 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
prism/prism.c
View File

@ -962,17 +962,19 @@ pm_locals_order(PRISM_ATTRIBUTE_UNUSED pm_parser_t *parser, pm_locals_t *locals,
pm_constant_id_list_insert(list, (size_t) local->index, local->name); pm_constant_id_list_insert(list, (size_t) local->index, local->name);
if (warn_unused && local->reads == 0) { if (warn_unused && local->reads == 0) {
pm_constant_t *constant = pm_constant_pool_id_to_constant(&parser->constant_pool, local->name); if (pm_newline_list_line(&parser->newline_list, local->location.start, parser->start_line) >= 0) {
pm_constant_t *constant = pm_constant_pool_id_to_constant(&parser->constant_pool, local->name);
if (constant->length >= 1 && *constant->start != '_') { if (constant->length >= 1 && *constant->start != '_') {
PM_PARSER_WARN_FORMAT( PM_PARSER_WARN_FORMAT(
parser, parser,
local->location.start, local->location.start,
local->location.end, local->location.end,
PM_WARN_UNUSED_LOCAL_VARIABLE, PM_WARN_UNUSED_LOCAL_VARIABLE,
(int) constant->length, (int) constant->length,
(const char *) constant->start (const char *) constant->start
); );
}
} }
} }
} }

2
test/prism/result/warnings_test.rb
View File

@ -259,6 +259,8 @@ module Prism
refute_warning("def foo; bar = 1; tap { bar }; end") refute_warning("def foo; bar = 1; tap { bar }; end")
refute_warning("def foo; bar = 1; tap { baz = bar; baz }; end") refute_warning("def foo; bar = 1; tap { baz = bar; baz }; end")
refute_warning("def foo; bar = 1; end", line: -2, compare: false)
end end
def test_void_statements def test_void_statements