1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

YJIT: Deallocate when assumptions tables are empty

Browse Source 
When we run global invalidation for TracePoints or code GC, we clear out
all blocks in our assumptions table but we don't deallocate the backing
buffers. Let's reclaim some memory during these rare events.
This commit is contained in:
Alan Wu 2022-11-29 15:41:25 -05:00 committed by Maxime Chevalier-Boisvert
parent 03f1e6a2aa
commit b30248f74a
Notes: git 2022-11-30 17:24:09 +00:00 
Merged: https://github.com/ruby/ruby/pull/6833
1 changed files with 28 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
yjit/src/invariants.rs
View File

@ -357,8 +357,14 @@ pub fn block_assumptions_free(blockref: &BlockRef) {
// Remove tracking for cme validity
if let Some(blockset) = invariants.cme_validity.get_mut(dep) {
blockset.remove(blockref);
if blockset.is_empty() {
invariants.cme_validity.remove(dep);
}
}
}
if invariants.cme_validity.is_empty() {
invariants.cme_validity.shrink_to_fit();
}
}
// Remove tracking for basic operators that the given block assumes have
@ -369,20 +375,42 @@ pub fn block_assumptions_free(blockref: &BlockRef) {
for key in &bops {
if let Some(blocks) = invariants.basic_operator_blocks.get_mut(key) {
blocks.remove(&blockref);
if blocks.is_empty() {
invariants.basic_operator_blocks.remove(key);
}
}
}
}
if invariants.block_basic_operators.is_empty() {
invariants.block_basic_operators.shrink_to_fit();
}
if invariants.basic_operator_blocks.is_empty() {
invariants.basic_operator_blocks.shrink_to_fit();
}
// Remove tracking for blocks assuming single ractor mode
invariants.single_ractor.remove(&blockref);
if invariants.single_ractor.is_empty() {
invariants.single_ractor.shrink_to_fit();
}
// Remove tracking for constant state for a given ID.
if let Some(ids) = invariants.block_constant_states.remove(&blockref) {
for id in ids {
if let Some(blocks) = invariants.constant_state_blocks.get_mut(&id) {
blocks.remove(&blockref);
if blocks.is_empty() {
invariants.constant_state_blocks.remove(&id);
}
}
}
}
if invariants.block_constant_states.is_empty() {
invariants.block_constant_states.shrink_to_fit();
}
if invariants.constant_state_blocks.is_empty() {
invariants.constant_state_blocks.shrink_to_fit();
}
}
/// Callback from the opt_setinlinecache instruction in the interpreter.