1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Bug #21008] Normalize before sum to float

Browse Source 
After switching to `Float`-mode when summing `Numeric` objects,
normalization for `Float` is still needed.
This commit is contained in:
Nobuyoshi Nakada 2025-01-07 11:38:51 +09:00
parent e9593eb967
commit b176d4f52e
No known key found for this signature in database
GPG Key ID: 3582D74E1FEE4465
Notes: git 2025-01-07 04:14:23 +00:00 
Merged: https://github.com/ruby/ruby/pull/12522
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
enum.c
View File

@ -4704,7 +4704,7 @@ sum_iter(VALUE i, struct enum_sum_memo *memo)
} }
else switch (TYPE(memo->v)) { else switch (TYPE(memo->v)) {
default: sum_iter_some_value(i, memo); return; default: sum_iter_some_value(i, memo); return;
case T_FLOAT: sum_iter_Kahan_Babuska(i, memo); return; case T_FLOAT:
case T_FIXNUM: case T_FIXNUM:
case T_BIGNUM: case T_BIGNUM:
case T_RATIONAL: case T_RATIONAL:

15
test/ruby/test_enumerator.rb
View File

@ -1043,4 +1043,19 @@ class TestEnumerator < Test::Unit::TestCase
assert_raise(FrozenError) { e.feed 1 } assert_raise(FrozenError) { e.feed 1 }
assert_raise(FrozenError) { e.rewind } assert_raise(FrozenError) { e.rewind }
end end
def test_sum_of_numeric
num = Class.new(Numeric) do
attr_reader :to_f
def initialize(val)
@to_f = Float(val)
end
end
ary = [5, 10, 20].map {|i| num.new(i)}
assert_equal(35.0, ary.sum)
enum = ary.each
assert_equal(35.0, enum.sum)
end
end end