From b148dfef5aa208cafa28626fd84c9762bfdfe0ac Mon Sep 17 00:00:00 2001 From: Luke Jahnke Date: Fri, 14 Mar 2025 23:38:33 +1000 Subject: [PATCH] Fix crash in TCPSocket.open Fix segfault crash observable with TCPSocket.open(nil, nil) --- ext/socket/ipsocket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/socket/ipsocket.c b/ext/socket/ipsocket.c index efaca265d5..60776c16a2 100644 --- a/ext/socket/ipsocket.c +++ b/ext/socket/ipsocket.c @@ -593,7 +593,7 @@ init_fast_fallback_inetsock_internal(VALUE v) arg->getaddrinfo_shared->notify = hostname_resolution_notifier; arg->getaddrinfo_shared->node = arg->hostp ? ruby_strdup(arg->hostp) : NULL; - arg->getaddrinfo_shared->service = ruby_strdup(arg->portp); + arg->getaddrinfo_shared->service = arg->portp ? ruby_strdup(arg->portp) : NULL; arg->getaddrinfo_shared->refcount = arg->family_size + 1; for (int i = 0; i < arg->family_size; i++) {