* ext/psych/lib/psych/scalar_scanner.rb: strip trailing dots from

floats so that Float() will not raise an exception.

* test/psych/test_numeric.rb: test to ensure "1." can be loaded

* test/psych/test_string.rb: make sure "1." can round trip

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@38754 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
tenderlove 2013-01-09 19:26:45 +00:00
parent ac8b1869c0
commit b104e2524d
4 changed files with 18 additions and 1 deletions

View File

@ -1,3 +1,12 @@
Thu Jan 10 04:23:07 2013 Aaron Patterson <aaron@tenderlovemaking.com>
* ext/psych/lib/psych/scalar_scanner.rb: strip trailing dots from
floats so that Float() will not raise an exception.
* test/psych/test_numeric.rb: test to ensure "1." can be loaded
* test/psych/test_string.rb: make sure "1." can round trip
Thu Jan 10 03:38:40 2013 Aaron Patterson <aaron@tenderlovemaking.com> Thu Jan 10 03:38:40 2013 Aaron Patterson <aaron@tenderlovemaking.com>
* ext/psych/lib/psych/visitors/yaml_tree.rb: ascii only binary strings * ext/psych/lib/psych/visitors/yaml_tree.rb: ascii only binary strings

View File

@ -96,7 +96,7 @@ module Psych
@string_cache[string] = true @string_cache[string] = true
string string
else else
Float(string.gsub(/[,_]/, '')) Float(string.gsub(/[,_]|\.$/, ''))
end end
else else
int = parse_int string.gsub(/[,_]/, '') int = parse_int string.gsub(/[,_]/, '')

View File

@ -16,6 +16,10 @@ module Psych
$DEBUG = @old_debug $DEBUG = @old_debug
end end
def test_load_float_with_dot
assert_equal 1.0, Psych.load('--- 1.')
end
def test_non_float_with_0 def test_non_float_with_0
str = Psych.load('--- 090') str = Psych.load('--- 090')
assert_equal '090', str assert_equal '090', str

View File

@ -102,6 +102,10 @@ module Psych
assert_cycle string assert_cycle string
end end
def test_float_confusion
assert_cycle '1.'
end
def binary_string percentage = 0.31, length = 100 def binary_string percentage = 0.31, length = 100
string = '' string = ''
(percentage * length).to_i.times do |i| (percentage * length).to_i.times do |i|