From b06649b91262c9462933bef8c8f6173c2abe59d2 Mon Sep 17 00:00:00 2001 From: mame Date: Wed, 7 Nov 2018 08:13:20 +0000 Subject: [PATCH] Rename get/setinlinecache to opt_get/opt_setinlinecache The instructions are just for optimization. To clarity the intention, this change adds the prefix "opt_", like "opt_case_dispatch". git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65600 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- compile.c | 12 ++++++------ insns.def | 4 ++-- test/ruby/test_jit.rb | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/compile.c b/compile.c index 9e5c05397d..36df0b0e8a 100644 --- a/compile.c +++ b/compile.c @@ -6829,9 +6829,9 @@ iseq_compile_each0(rb_iseq_t *iseq, LINK_ANCHOR *const ret, const NODE *node, in LABEL *lend = NEW_LABEL(line); int ic_index = body->is_size++; - ADD_INSN2(ret, line, getinlinecache, lend, INT2FIX(ic_index)); + ADD_INSN2(ret, line, opt_getinlinecache, lend, INT2FIX(ic_index)); ADD_INSN1(ret, line, getconstant, ID2SYM(node->nd_vid)); - ADD_INSN1(ret, line, setinlinecache, INT2FIX(ic_index)); + ADD_INSN1(ret, line, opt_setinlinecache, INT2FIX(ic_index)); ADD_LABEL(ret, lend); } else { @@ -7187,7 +7187,7 @@ iseq_compile_each0(rb_iseq_t *iseq, LINK_ANCHOR *const ret, const NODE *node, in CHECK(compile_const_prefix(iseq, node, pref, body)); if (LIST_INSN_SIZE_ZERO(pref)) { if (ISEQ_COMPILE_DATA(iseq)->option->inline_const_cache) { - ADD_INSN2(ret, line, getinlinecache, lend, INT2FIX(ic_index)); + ADD_INSN2(ret, line, opt_getinlinecache, lend, INT2FIX(ic_index)); } else { ADD_INSN(ret, line, putnil); @@ -7196,7 +7196,7 @@ iseq_compile_each0(rb_iseq_t *iseq, LINK_ANCHOR *const ret, const NODE *node, in ADD_SEQ(ret, body); if (ISEQ_COMPILE_DATA(iseq)->option->inline_const_cache) { - ADD_INSN1(ret, line, setinlinecache, INT2FIX(ic_index)); + ADD_INSN1(ret, line, opt_setinlinecache, INT2FIX(ic_index)); ADD_LABEL(ret, lend); } } @@ -7224,7 +7224,7 @@ iseq_compile_each0(rb_iseq_t *iseq, LINK_ANCHOR *const ret, const NODE *node, in /* add cache insn */ if (ISEQ_COMPILE_DATA(iseq)->option->inline_const_cache) { - ADD_INSN2(ret, line, getinlinecache, lend, INT2FIX(ic_index)); + ADD_INSN2(ret, line, opt_getinlinecache, lend, INT2FIX(ic_index)); ADD_INSN(ret, line, pop); } @@ -7232,7 +7232,7 @@ iseq_compile_each0(rb_iseq_t *iseq, LINK_ANCHOR *const ret, const NODE *node, in ADD_INSN1(ret, line, getconstant, ID2SYM(node->nd_mid)); if (ISEQ_COMPILE_DATA(iseq)->option->inline_const_cache) { - ADD_INSN1(ret, line, setinlinecache, INT2FIX(ic_index)); + ADD_INSN1(ret, line, opt_setinlinecache, INT2FIX(ic_index)); ADD_LABEL(ret, lend); } diff --git a/insns.def b/insns.def index e77dc1fe54..efd5bb74a2 100644 --- a/insns.def +++ b/insns.def @@ -985,7 +985,7 @@ branchnil /* push inline-cached value and go to dst if it is valid */ DEFINE_INSN -getinlinecache +opt_getinlinecache (OFFSET dst, IC ic) () (VALUE val) @@ -1001,7 +1001,7 @@ getinlinecache /* set inline cache */ DEFINE_INSN -setinlinecache +opt_setinlinecache (IC ic) (VALUE val) (VALUE val) diff --git a/test/ruby/test_jit.rb b/test/ruby/test_jit.rb index 5c31b504c4..dbc8732e4c 100644 --- a/test/ruby/test_jit.rb +++ b/test/ruby/test_jit.rb @@ -444,7 +444,7 @@ class TestJIT < Test::Unit::TestCase end def test_compile_insn_inlinecache - assert_compile_once('Struct', result_inspect: 'Struct', insns: %i[getinlinecache setinlinecache]) + assert_compile_once('Struct', result_inspect: 'Struct', insns: %i[opt_getinlinecache opt_setinlinecache]) end def test_compile_insn_once