1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ruby/openssl] ssl: fix test case test_npn_advertised_protocol_too_long

Browse Source 
The list of NPN protocols is validated in SSLContext#setup.

The assert_handshake_error is misleading. The client is unable to start
a handshake at all because the server is not running.

https://github.com/ruby/openssl/commit/e8db6ffd9e
This commit is contained in:
Kazuki Yamaguchi 2025-02-06 23:55:49 +09:00 committed by git
parent 1f4fc2e608
commit a8b36314ec
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
test/openssl/test_ssl.rb
View File

@ -1639,12 +1639,11 @@ class OpenSSL::TestSSL < OpenSSL::SSLTestCase
def test_npn_advertised_protocol_too_long def test_npn_advertised_protocol_too_long
return unless OpenSSL::SSL::SSLContext.method_defined?(:npn_select_cb) return unless OpenSSL::SSL::SSLContext.method_defined?(:npn_select_cb)
ctx_proc = Proc.new { |ctx| ctx.npn_protocols = ["a" * 256] } ctx = OpenSSL::SSL::SSLContext.new
start_server_version(:TLSv1_2, ctx_proc) { |port| assert_raise(OpenSSL::SSL::SSLError) do
ctx = OpenSSL::SSL::SSLContext.new ctx.npn_protocols = ["a" * 256]
ctx.npn_select_cb = -> (protocols) { protocols.first } ctx.setup
assert_handshake_error { server_connect(port, ctx) } end
}
end end
def test_npn_selected_protocol_too_long def test_npn_selected_protocol_too_long