[rubygems/rubygems] Add missing Windows job
Specs that use extension gems were failing in the new job but I noticed that they were using very non standard `extconf.rb` files. The hack being removed here was added just to make specs pass when run in ruby-core but it seems the underlying issue has been fixed now, and it's causing issues with Ruby 3.3 and Windows, so necessary so I'm removing it and moving on. https://github.com/rubygems/rubygems/commit/5b78275f0e
This commit is contained in:
parent
ccffc6ee09
commit
a4e4e3b1f1
@ -1279,7 +1279,6 @@ RSpec.describe "bundle install with git sources" do
|
||||
s.extensions = ["ext/extconf.rb"]
|
||||
s.write "ext/extconf.rb", <<-RUBY
|
||||
require "mkmf"
|
||||
$extout = "$(topdir)/" + RbConfig::CONFIG["EXTOUT"]
|
||||
create_makefile("foo")
|
||||
RUBY
|
||||
s.write "ext/foo.c", "void Init_foo() {}"
|
||||
|
@ -7,7 +7,6 @@ RSpec.describe "installing a gem with native extensions" do
|
||||
s.extensions = ["ext/extconf.rb"]
|
||||
s.write "ext/extconf.rb", <<-E
|
||||
require "mkmf"
|
||||
$extout = "$(topdir)/" + RbConfig::CONFIG["EXTOUT"]
|
||||
name = "c_extension_bundle"
|
||||
dir_config(name)
|
||||
raise "OMG" unless with_config("c_extension") == "hello"
|
||||
@ -52,7 +51,6 @@ RSpec.describe "installing a gem with native extensions" do
|
||||
s.extensions = ["ext/extconf.rb"]
|
||||
s.write "ext/extconf.rb", <<-E
|
||||
require "mkmf"
|
||||
$extout = "$(topdir)/" + RbConfig::CONFIG["EXTOUT"]
|
||||
name = "c_extension_bundle"
|
||||
dir_config(name)
|
||||
raise "OMG" unless with_config("c_extension") == "hello"
|
||||
@ -97,7 +95,6 @@ RSpec.describe "installing a gem with native extensions" do
|
||||
s.extensions = ["ext/extconf.rb"]
|
||||
s.write "ext/extconf.rb", <<-E
|
||||
require "mkmf"
|
||||
$extout = "$(topdir)/" + RbConfig::CONFIG["EXTOUT"]
|
||||
name = "c_extension_bundle_#{n}"
|
||||
dir_config(name)
|
||||
raise "OMG" unless with_config("c_extension_#{n}") == "#{n}"
|
||||
@ -150,7 +147,6 @@ RSpec.describe "installing a gem with native extensions" do
|
||||
s.extensions = ["ext/extconf.rb"]
|
||||
s.write "ext/extconf.rb", <<-E
|
||||
require "mkmf"
|
||||
$extout = "$(topdir)/" + RbConfig::CONFIG["EXTOUT"]
|
||||
name = "c_extension_bundle"
|
||||
dir_config(name)
|
||||
raise "OMG" unless with_config("c_extension") == "hello" && with_config("c_extension_bundle-dir") == "hola"
|
||||
|
@ -494,8 +494,6 @@ module Spec
|
||||
write "ext/extconf.rb", <<-RUBY
|
||||
require "mkmf"
|
||||
|
||||
$extout = "$(topdir)/" + RbConfig::CONFIG["EXTOUT"]
|
||||
|
||||
extension_name = "#{name}_c"
|
||||
if extra_lib_dir = with_config("ext-lib")
|
||||
# add extra libpath if --with-ext-lib is
|
||||
|
Loading…
x
Reference in New Issue
Block a user