1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MN: ceil timeout milli seconds

Browse Source 
`hrrel / RB_HRTIME_PER_MSEC` floor the timeout value and it can
return wrong value by `Mutex#sleep` (return Integer even if
it should return nil (timeout'ed)).

This patch ceil the value and the issue was solved.
This commit is contained in:
Koichi Sasada 2023-12-23 05:23:53 +09:00
parent c974ee1abe
commit a4b737213e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
thread_pthread.c
View File

@ -2872,7 +2872,7 @@ timer_thread_set_timeout(rb_vm_t *vm)
RUBY_DEBUG_LOG("th:%u now:%lu rel:%lu", rb_th_serial(th), (unsigned long)now, (unsigned long)hrrel);
// TODO: overflow?
timeout = (int)(hrrel / RB_HRTIME_PER_MSEC); // ms
timeout = (int)((hrrel + RB_HRTIME_PER_MSEC - 1) / RB_HRTIME_PER_MSEC); // ms
}
}
rb_native_mutex_unlock(&timer_th.waiting_lock);