1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[PRISM] Fixed StringConcatNode, uncommented tests

Browse Source
This commit is contained in:
Jemma Issroff 2023-10-18 17:14:13 -03:00
parent 8b3d044004
commit a426a230de
2 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
prism_compile.c
View File

@ -2429,6 +2429,9 @@ pm_compile_node(rb_iseq_t *iseq, const pm_node_t *node, LINK_ANCHOR *const ret,
pm_string_concat_node_t *str_concat_node = (pm_string_concat_node_t *)node; pm_string_concat_node_t *str_concat_node = (pm_string_concat_node_t *)node;
PM_COMPILE(str_concat_node->left); PM_COMPILE(str_concat_node->left);
PM_COMPILE(str_concat_node->right); PM_COMPILE(str_concat_node->right);
if (!popped) {
ADD_INSN1(ret, &dummy_line_node, concatstrings, INT2FIX(2));
}
return; return;
} }
case PM_STRING_NODE: { case PM_STRING_NODE: {

18
test/ruby/test_compile_prism.rb
View File

@ -241,8 +241,8 @@ module Prism
############################################################################ ############################################################################
def test_EmbeddedVariableNode def test_EmbeddedVariableNode
# test_prism_eval('class Prism::TestCompilePrism; @pit = 1; "#@pit"; end') test_prism_eval('class Prism::TestCompilePrism; @pit = 1; "#@pit"; end')
# test_prism_eval('class Prism::TestCompilePrism; @@pit = 1; "#@@pit"; end') test_prism_eval('class Prism::TestCompilePrism; @@pit = 1; "#@@pit"; end')
test_prism_eval('$pit = 1; "#$pit"') test_prism_eval('$pit = 1; "#$pit"')
end end
@ -284,7 +284,7 @@ module Prism
end end
def test_StringConcatNode def test_StringConcatNode
# test_prism_eval('"Prism" "::" "TestCompilePrism"') test_prism_eval('"Prism" "::" "TestCompilePrism"')
end end
def test_StringNode def test_StringNode
@ -296,12 +296,12 @@ module Prism
end end
def test_XStringNode def test_XStringNode
# test_prism_eval(<<~RUBY) test_prism_eval(<<~RUBY)
# class Prism::TestCompilePrism class Prism::TestCompilePrism
# def self.`(command) = command * 2 def self.`(command) = command * 2
# `pit` `pit`
# end end
# RUBY RUBY
end end
############################################################################ ############################################################################