1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix Issues reported by PVS-Studio static analyzer

Browse Source 
* vm.c (vm_set_main_stack): remove unnecessary check.  toplevel
  binding must be initialized.  [Bug #12611] (N1)
* win32/win32.c (w32_symlink): fix return type.  [Bug #12611] (N3)
* string.c (rb_str_split_m): simplify the condition.
  [Bug #12611](N4)

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55729 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
nobu 2016-07-22 10:55:22 +00:00
parent c6692d9410
commit a325876ad3
4 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ChangeLog
View File

@ -1,3 +1,13 @@
Fri Jul 22 19:55:20 2016 Nobuyoshi Nakada <nobu@ruby-lang.org>
* vm.c (vm_set_main_stack): remove unnecessary check. toplevel
binding must be initialized. [Bug #12611] (N1)
* win32/win32.c (w32_symlink): fix return type. [Bug #12611] (N3)
* string.c (rb_str_split_m): simplify the condition.
[Bug #12611](N4)
Fri Jul 22 17:13:37 2016 Martin Duerst <duerst@it.aoyama.ac.jp> Fri Jul 22 17:13:37 2016 Martin Duerst <duerst@it.aoyama.ac.jp>
* string.c (String#dump): Change escaping of non-ASCII characters in * string.c (String#dump): Change escaping of non-ASCII characters in

2
string.c
View File

@ -7235,7 +7235,7 @@ rb_str_split_m(int argc, VALUE *argv, VALUE str)
beg = start; beg = start;
} }
else { else {
if (ptr+start == ptr+len) if (start == len)
start++; start++;
else else
start += rb_enc_fast_mbclen(ptr+start,ptr+len,enc); start += rb_enc_fast_mbclen(ptr+start,ptr+len,enc);

2
vm.c
View File

@ -379,7 +379,7 @@ vm_set_main_stack(rb_thread_t *th, const rb_iseq_t *iseq)
vm_set_eval_stack(th, iseq, 0, &env->block); vm_set_eval_stack(th, iseq, 0, &env->block);
/* save binding */ /* save binding */
if (bind && iseq->body->local_size > 0) { if (iseq->body->local_size > 0) {
bind->env = vm_make_env_object(th, th->cfp); bind->env = vm_make_env_object(th, th->cfp);
} }
} }

2
win32/win32.c
View File

@ -4947,7 +4947,7 @@ w32_symlink(UINT cp, const char *src, const char *link)
DWORD flag = 0; DWORD flag = 0;
BOOLEAN ret; BOOLEAN ret;
typedef DWORD (WINAPI *create_symbolic_link_func)(WCHAR*, WCHAR*, DWORD); typedef BOOLEAN (WINAPI *create_symbolic_link_func)(WCHAR*, WCHAR*, DWORD);
static create_symbolic_link_func create_symbolic_link = static create_symbolic_link_func create_symbolic_link =
(create_symbolic_link_func)-1; (create_symbolic_link_func)-1;