1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Embed Backtrace::Location objects

Browse Source 
The struct is 16B, so they will use the 80B size pool, so on paper it
wastes 80 - 32 - 16 = 52B, however most malloc implementations will
either pad sizes or use an extra 16B for each segment, so in practice
the waste isn't that big. Also `Backtrace::Location` are rarely held
on for long, so avoiding the malloc churn help performance.

Co-Authored-By: Étienne Barrié <etienne.barrie@gmail.com>
This commit is contained in:
Jean Boussier 2023-11-10 10:21:28 +01:00 committed by Jean Boussier
parent 1ee6968855
commit a2442e91fd
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
vm_backtrace.c
View File

@ -162,14 +162,13 @@ location_mark_entry(rb_backtrace_location_t *fi)
static size_t static size_t
location_memsize(const void *ptr) location_memsize(const void *ptr)
{ {
/* rb_backtrace_location_t *fi = (rb_backtrace_location_t *)ptr; */ return 0;
return sizeof(rb_backtrace_location_t);
} }
static const rb_data_type_t location_data_type = { static const rb_data_type_t location_data_type = {
"frame_info", "frame_info",
{location_mark, RUBY_TYPED_DEFAULT_FREE, location_memsize,}, {location_mark, RUBY_TYPED_DEFAULT_FREE, location_memsize,},
0, 0, RUBY_TYPED_FREE_IMMEDIATELY | RUBY_TYPED_WB_PROTECTED 0, 0, RUBY_TYPED_FREE_IMMEDIATELY | RUBY_TYPED_WB_PROTECTED | RUBY_TYPED_EMBEDDABLE
}; };
int int
@ -182,7 +181,7 @@ static inline rb_backtrace_location_t *
location_ptr(VALUE locobj) location_ptr(VALUE locobj)
{ {
struct valued_frame_info *vloc; struct valued_frame_info *vloc;
GetCoreDataFromValue(locobj, struct valued_frame_info, vloc); TypedData_Get_Struct(locobj, struct valued_frame_info, &location_data_type, vloc);
return vloc->loc; return vloc->loc;
} }