1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary checks for empty kw splat

Browse Source 
These two checks are surrounded by an if that ensures the
call site is not a kw splat call site.
This commit is contained in:
Alan Wu 2021-04-23 19:37:03 -04:00 committed by GitHub
parent 4b36a597f4
commit a224ce8150
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
Notes: git 2021-04-24 08:37:23 +09:00 
Merged: https://github.com/ruby/ruby/pull/4404

Merged-By: XrXr
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
vm_insnhelper.c
View File

@ -2417,7 +2417,6 @@ vm_callee_setup_arg(rb_execution_context_t *ec, struct rb_calling_info *calling,
if (LIKELY(rb_simple_iseq_p(iseq))) { if (LIKELY(rb_simple_iseq_p(iseq))) {
rb_control_frame_t *cfp = ec->cfp; rb_control_frame_t *cfp = ec->cfp;
CALLER_SETUP_ARG(cfp, calling, ci); CALLER_SETUP_ARG(cfp, calling, ci);
CALLER_REMOVE_EMPTY_KW_SPLAT(cfp, calling, ci);
if (calling->argc != iseq->body->param.lead_num) { if (calling->argc != iseq->body->param.lead_num) {
argument_arity_error(ec, iseq, calling->argc, iseq->body->param.lead_num, iseq->body->param.lead_num); argument_arity_error(ec, iseq, calling->argc, iseq->body->param.lead_num, iseq->body->param.lead_num);
@ -2431,7 +2430,6 @@ vm_callee_setup_arg(rb_execution_context_t *ec, struct rb_calling_info *calling,
else if (rb_iseq_only_optparam_p(iseq)) { else if (rb_iseq_only_optparam_p(iseq)) {
rb_control_frame_t *cfp = ec->cfp; rb_control_frame_t *cfp = ec->cfp;
CALLER_SETUP_ARG(cfp, calling, ci); CALLER_SETUP_ARG(cfp, calling, ci);
CALLER_REMOVE_EMPTY_KW_SPLAT(cfp, calling, ci);
const int lead_num = iseq->body->param.lead_num; const int lead_num = iseq->body->param.lead_num;
const int opt_num = iseq->body->param.opt_num; const int opt_num = iseq->body->param.opt_num;