1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ruby/yarp] Name test methods from relative paths

Browse Source 
Full path name of the source directory is a useless noise as tests.

https://github.com/ruby/yarp/commit/44a7ae2e64
This commit is contained in:
Nobuyoshi Nakada 2023-06-23 19:16:16 +09:00
parent 261e3663fd
commit 97152d44dc
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/yarp/parse_test.rb
View File

@ -61,15 +61,16 @@ class ParseTest < Test::Unit::TestCase
assert_equal filepath, find_source_file_node(parsed_result.value).filepath assert_equal filepath, find_source_file_node(parsed_result.value).filepath
end end
Dir[File.expand_path("fixtures/**/*.txt", __dir__)].each do |filepath| base = File.join(__dir__, "fixtures")
relative = filepath.delete_prefix("#{File.expand_path("fixtures", __dir__)}/") Dir["**/*.txt", base: base].each do |relative|
next if known_failures.include?(relative) next if known_failures.include?(relative)
filepath = File.join(base, relative)
snapshot = File.expand_path(File.join("snapshots", relative), __dir__) snapshot = File.expand_path(File.join("snapshots", relative), __dir__)
directory = File.dirname(snapshot) directory = File.dirname(snapshot)
FileUtils.mkdir_p(directory) unless File.directory?(directory) FileUtils.mkdir_p(directory) unless File.directory?(directory)
define_method "test_filepath_#{filepath}" do define_method "test_filepath_#{relative}" do
# First, read the source from the filepath. Use binmode to avoid converting CRLF on Windows, # First, read the source from the filepath. Use binmode to avoid converting CRLF on Windows,
# and explicitly set the external encoding to UTF-8 to override the binmode default. # and explicitly set the external encoding to UTF-8 to override the binmode default.
source = File.read(filepath, binmode: true, external_encoding: Encoding::UTF_8) source = File.read(filepath, binmode: true, external_encoding: Encoding::UTF_8)