1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[rubygems/rubygems] Close then unlink tempfiles on Windows

Browse Source 
In ruby/ruby test actions, number of "leaked tempfile" messages
are shown on Windows.

As Windows disallows removing open files, `Tempfile#unlink` fails
silently before `#close`.
Close then unlink by `#close!` instead.

https://github.com/rubygems/rubygems/commit/fe0b88ac30
This commit is contained in:
Nobuyoshi Nakada 2021-06-17 12:13:13 +09:00
parent e4f891ce8d
commit 95ef545997
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/rubygems/helper.rb
View File

@ -153,15 +153,13 @@ class Gem::TestCase < Test::Unit::TestCase
return captured_stdout.read, captured_stderr.read return captured_stdout.read, captured_stderr.read
ensure ensure
captured_stdout.unlink
captured_stderr.unlink
$stdout.reopen orig_stdout $stdout.reopen orig_stdout
$stderr.reopen orig_stderr $stderr.reopen orig_stderr
orig_stdout.close orig_stdout.close
orig_stderr.close orig_stderr.close
captured_stdout.close captured_stdout.close!
captured_stderr.close captured_stderr.close!
end end
end end
end end