1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Eliminate array allocation for f(*a, **lvar, &lvar) and f(*a, **@iv, &@iv)

Browse Source 
The compiler already eliminates the array allocation for
f(*a, &lvar) and f(*a, &@iv).  If that is safe, then eliminating
it for f(*a, **lvar) and f(*a, **@iv) as the last commit did is
as safe, and eliminating it for f(*a, **lvar, &lvar) and
f(*a, **@iv, &@iv) is also as safe.
This commit is contained in:
Jeremy Evans 2023-11-06 12:39:57 -08:00
parent 1731dd05a7
commit 95615872e3
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
compile.c
View File

@ -3892,6 +3892,30 @@ iseq_peephole_optimize(rb_iseq_t *iseq, LINK_ELEMENT *list, const int do_tailcal
OPERAND_AT(iobj, 0) = Qfalse; OPERAND_AT(iobj, 0) = Qfalse;
} }
} }
} else if (IS_NEXT_INSN_ID(niobj, getlocal) || IS_NEXT_INSN_ID(niobj, getinstancevariable)) {
niobj = niobj->next;
/*
* Eliminate array allocation for f(*a, **lvar, &lvar) and f(*a, **@iv, &@iv)
*
* splatarray true
* getlocal / getinstancevariable
* getlocal / getinstancevariable
* send ARGS_SPLAT|KW_SPLAT|ARGS_BLOCKARG
* =>
* splatarray false
* getlocal / getinstancevariable
* getlocal / getinstancevariable
* send
*/
if (IS_NEXT_INSN_ID(niobj, send)) {
niobj = niobj->next;
unsigned int flag = vm_ci_flag((const struct rb_callinfo *)OPERAND_AT(niobj, 0));
if ((flag & VM_CALL_ARGS_SPLAT) && (flag & VM_CALL_KW_SPLAT) && (flag & VM_CALL_ARGS_BLOCKARG)) {
OPERAND_AT(iobj, 0) = Qfalse;
}
}
} }
} }
} }