1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Delete from finalizer_table before running finalizer

Browse Source 
The finalizer could trigger a GC, which would cause FL_FINALIZE to be
out of sync with the finalizer table.
This commit is contained in:
Peter Zhu 2024-02-29 09:36:01 -05:00
parent d5bca0668c
commit 950c60623b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gc.c
View File

@ -4304,11 +4304,11 @@ rb_objspace_call_finalizer(rb_objspace_t *objspace)
while (list) { while (list) {
struct force_finalize_list *curr = list; struct force_finalize_list *curr = list;
FL_UNSET(curr->obj, FL_FINALIZE);
run_finalizer(objspace, curr->obj, curr->table);
st_data_t obj = (st_data_t)curr->obj; st_data_t obj = (st_data_t)curr->obj;
st_delete(finalizer_table, &obj, 0); st_delete(finalizer_table, &obj, 0);
FL_UNSET(curr->obj, FL_FINALIZE);
run_finalizer(objspace, curr->obj, curr->table);
list = curr->next; list = curr->next;
xfree(curr); xfree(curr);