From 92986313161c36157187ed7078fc4909bbf9bc04 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=8D=9C=E9=83=A8=E6=98=8C=E5=B9=B3?=
 <shyouhei@ruby-lang.org>
Date: Tue, 16 Jun 2020 12:27:33 +0900
Subject: [PATCH] check_exec_redirect_fd: do not goto into a branch

I'm not necessarily against every goto in general, but jumping into a
branch is definitely a bad idea.  Better refactor.
---
 process.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/process.c b/process.c
index 5e47a518c5..054c303679 100644
--- a/process.c
+++ b/process.c
@@ -1886,8 +1886,7 @@ check_exec_redirect_fd(VALUE v, int iskey)
         fd = fptr->fd;
     }
     else {
-      wrong:
-        rb_raise(rb_eArgError, "wrong exec redirect");
+        goto wrong;
     }
     if (fd < 0) {
         rb_raise(rb_eArgError, "negative file descriptor");
@@ -1898,6 +1897,9 @@ check_exec_redirect_fd(VALUE v, int iskey)
     }
 #endif
     return INT2FIX(fd);
+
+  wrong:
+    rb_raise(rb_eArgError, "wrong exec redirect");
 }
 
 static VALUE