1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ruby/open-uri] Update error message for request_specific_fields option validation

Browse Source 
Added `inspect` to the `request_specific_fields` value to provide
better visibility for users in the exception message.

https://github.com/ruby/open-uri/commit/f89ce5112d
This commit is contained in:
otegami 2024-09-06 09:32:15 +09:00 committed by git
parent 76475bf5c0
commit 903f3790ad
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/open-uri.rb
View File

@ -151,7 +151,7 @@ module OpenURI
end end
if options.has_key? :request_specific_fields if options.has_key? :request_specific_fields
if !(options[:request_specific_fields].is_a?(Hash) || options[:request_specific_fields].is_a?(Proc)) if !(options[:request_specific_fields].is_a?(Hash) || options[:request_specific_fields].is_a?(Proc))
raise ArgumentError, "Invalid request_specific_fields' format: #{options[:request_specific_fields]}" raise ArgumentError, "Invalid request_specific_fields option: #{options[:request_specific_fields].inspect}"
end end
end end
unless mode == nil || unless mode == nil ||

2
test/open-uri/test_open-uri.rb
View File

@ -393,7 +393,7 @@ class TestOpenURI < Test::Unit::TestCase
with_http {|srv, url| with_http {|srv, url|
srv.mount_proc("/r1/", lambda {|req, res| res.body = "r1" } ) srv.mount_proc("/r1/", lambda {|req, res| res.body = "r1" } )
exc = assert_raise(ArgumentError) { URI.open("#{url}/r1/", request_specific_fields: "dummy_token") {} } exc = assert_raise(ArgumentError) { URI.open("#{url}/r1/", request_specific_fields: "dummy_token") {} }
assert_equal("Invalid request_specific_fields' format: dummy_token", exc.message) assert_equal('Invalid request_specific_fields option: "dummy_token"', exc.message)
} }
end end