From 900e0c8c39fe3df72d7ce451e01c1add7b6f1647 Mon Sep 17 00:00:00 2001 From: Nobuyoshi Nakada Date: Tue, 14 Dec 2021 00:55:02 +0900 Subject: [PATCH] [ruby/securerandom] Use String#unpack1 https://github.com/ruby/securerandom/commit/5460a18c35 --- lib/random/formatter.rb | 2 +- test/ruby/test_random_formatter.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/random/formatter.rb b/lib/random/formatter.rb index d7e7b1f77a..744853a4b7 100644 --- a/lib/random/formatter.rb +++ b/lib/random/formatter.rb @@ -71,7 +71,7 @@ module Random::Formatter # prng.hex #=> "eb693ec8252cd630102fd0d0fb7c3485" # prng.hex #=> "91dc3bfb4de5b11d029d376634589b61" def hex(n=nil) - random_bytes(n).unpack("H*")[0] + random_bytes(n).unpack1("H*") end # Random::Formatter#base64 generates a random base64 string. diff --git a/test/ruby/test_random_formatter.rb b/test/ruby/test_random_formatter.rb index df3320b41c..a5072099e1 100644 --- a/test/ruby/test_random_formatter.rb +++ b/test/ruby/test_random_formatter.rb @@ -27,9 +27,9 @@ module Random::Formatter end def test_base64 - assert_equal(16, @it.base64.unpack('m*')[0].size) + assert_equal(16, @it.base64.unpack1('m*').size) 17.times do |idx| - assert_equal(idx, @it.base64(idx).unpack('m*')[0].size) + assert_equal(idx, @it.base64(idx).unpack1('m*').size) end end