1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Warn the defined location as deprecation as well as the main message

Browse Source 
[Bug #17575]
This commit is contained in:
Nobuyoshi Nakada 2021-01-23 19:57:07 +09:00
parent 62283f7a7a
commit 8dfae85adb
No known key found for this signature in database
GPG Key ID: 7CD2805BFA3770C6
2 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
test/ruby/test_defined.rb
View File

@ -258,6 +258,23 @@ class TestDefined < Test::Unit::TestCase
assert_separately([], "assert_nil(defined?(super))") assert_separately([], "assert_nil(defined?(super))")
end end
def test_respond_to
obj = "#{self.class.name}##{__method__}"
class << obj
def respond_to?(mid)
true
end
end
assert_warn(/deprecated method signature.*\n.*respond_to\? is defined here/) do
Warning[:deprecated] = true
defined?(obj.foo)
end
assert_warn('') do
Warning[:deprecated] = false
defined?(obj.foo)
end
end
class ExampleRespondToMissing class ExampleRespondToMissing
attr_reader :called attr_reader :called

3
vm_method.c
View File

@ -2503,7 +2503,8 @@ vm_respond_to(rb_execution_context_t *ec, VALUE klass, VALUE obj, ID id, int pri
VALUE path = RARRAY_AREF(location, 0); VALUE path = RARRAY_AREF(location, 0);
VALUE line = RARRAY_AREF(location, 1); VALUE line = RARRAY_AREF(location, 1);
if (!NIL_P(path)) { if (!NIL_P(path)) {
rb_compile_warn(RSTRING_PTR(path), NUM2INT(line), rb_category_compile_warn(RB_WARN_CATEGORY_DEPRECATED,
RSTRING_PTR(path), NUM2INT(line),
"respond_to? is defined here"); "respond_to? is defined here");
} }
} }