1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

RJIT: Avoid retaining comments unless --rjit-dump-disasm

Browse Source 
This significantly reduces retained objects on RJIT.
This commit is contained in:
Takashi Kokubun 2023-12-18 22:21:31 -08:00
parent 8671cd59f7
commit 8d5af353b2
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/ruby_vm/rjit/code_block.rb
View File

@ -4,7 +4,7 @@ module RubyVM::RJIT
# @param mem_size [Integer] JIT buffer size # @param mem_size [Integer] JIT buffer size
# @param outliend [TrueClass,FalseClass] true for outlined CodeBlock # @param outliend [TrueClass,FalseClass] true for outlined CodeBlock
def initialize(mem_block:, mem_size:, outlined: false) def initialize(mem_block:, mem_size:, outlined: false)
@comments = Hash.new { |h, k| h[k] = [] } @comments = Hash.new { |h, k| h[k] = [] } if dump_disasm?
@mem_block = mem_block @mem_block = mem_block
@mem_size = mem_size @mem_size = mem_size
@write_pos = 0 @write_pos = 0
@ -26,7 +26,7 @@ module RubyVM::RJIT
# Convert comment indexes to addresses # Convert comment indexes to addresses
asm.comments.each do |index, comments| asm.comments.each do |index, comments|
@comments[start_addr + index] += comments @comments[start_addr + index] += comments if dump_disasm?
end end
asm.comments.clear asm.comments.clear
@ -39,7 +39,7 @@ module RubyVM::RJIT
def set_write_addr(addr) def set_write_addr(addr)
@write_pos = addr - @mem_block @write_pos = addr - @mem_block
@comments.delete(addr) # TODO: clean up old comments for all the overwritten range? @comments.delete(addr) if dump_disasm?
end end
def with_write_addr(addr) def with_write_addr(addr)
@ -83,5 +83,9 @@ module RubyVM::RJIT
def bold(text) def bold(text)
"\e[1m#{text}\e[0m" "\e[1m#{text}\e[0m"
end end
def dump_disasm?
C.rjit_opts.dump_disasm
end
end end
end end