From 8c440619289b4e20c7b6b0e1b1a5a5c9a4252530 Mon Sep 17 00:00:00 2001
From: nobu <nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>
Date: Fri, 24 Feb 2017 09:39:17 +0000
Subject: [PATCH] Integer.sqrt argument check

* numeric.c (rb_int_s_isqrt): check if the argument is an integer.
  [Feature #13219]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57706 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
---
 numeric.c                 | 4 ++--
 test/ruby/test_integer.rb | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/numeric.c b/numeric.c
index 2784b6dd86..b34fb0a5f9 100644
--- a/numeric.c
+++ b/numeric.c
@@ -5158,6 +5158,7 @@ static VALUE
 rb_int_s_isqrt(VALUE self, VALUE num)
 {
     unsigned long n, sq;
+    num = rb_to_int(num);
     if (FIXNUM_P(num)) {
 	if (FIXNUM_NEGATIVE_P(num)) {
 	    domain_error("isqrt");
@@ -5166,7 +5167,7 @@ rb_int_s_isqrt(VALUE self, VALUE num)
 	sq = rb_ulong_isqrt(n);
 	return LONG2FIX(sq);
     }
-    if (RB_TYPE_P(num, T_BIGNUM)) {
+    else {
 	size_t biglen;
 	if (RBIGNUM_NEGATIVE_P(num)) {
 	    domain_error("isqrt");
@@ -5183,7 +5184,6 @@ rb_int_s_isqrt(VALUE self, VALUE num)
 #endif
 	return rb_big_isqrt(num);
     }
-    return Qnil;
 }
 
 /*
diff --git a/test/ruby/test_integer.rb b/test/ruby/test_integer.rb
index 05b0b68ccc..e0927c9ffe 100644
--- a/test/ruby/test_integer.rb
+++ b/test/ruby/test_integer.rb
@@ -466,6 +466,7 @@ class TestInteger < Test::Unit::TestCase
   end
 
   def test_square_root
+    assert_raise(TypeError) {Integer.sqrt("x")}
     assert_raise(Math::DomainError) {Integer.sqrt(-1)}
     assert_equal(0, Integer.sqrt(0))
     (1...4).each {|i| assert_equal(1, Integer.sqrt(i))}