1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Skip assertion in gc/default.c when multi-Ractor

Browse Source 
The counter for total allocated objects may not be accurate when there are
multiple Ractors since it is not atomic so there could be race conditions
when it is incremented.
This commit is contained in:
Peter Zhu 2024-08-26 10:59:57 -04:00
parent 1cafc9d51d
commit 8c01dec827
Notes: git 2024-08-26 17:25:31 +00:00 
Merged: https://github.com/ruby/ruby/pull/11462
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gc/default.c
View File

@ -2637,8 +2637,9 @@ newobj_alloc(rb_objspace_t *objspace, rb_ractor_newobj_cache_t *cache, size_t si
rb_size_pool_t *size_pool = &size_pools[size_pool_idx];
size_pool->total_allocated_objects++;
GC_ASSERT(SIZE_POOL_EDEN_HEAP(size_pool)->total_slots + SIZE_POOL_TOMB_HEAP(size_pool)->total_slots >=
(size_pool->total_allocated_objects - size_pool->total_freed_objects - size_pool->final_slots_count));
GC_ASSERT(rb_gc_multi_ractor_p() ||
SIZE_POOL_EDEN_HEAP(size_pool)->total_slots + SIZE_POOL_TOMB_HEAP(size_pool)->total_slots >=
(size_pool->total_allocated_objects - size_pool->total_freed_objects - size_pool->final_slots_count));
return obj;
}