1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Unskip the test skipped in #4173 (#7809)

Browse Source 
This test was skipped 12 years ago because it was flaky on FreeBSD and
OpenBSD. Since then, Ruby's SIGCHLD handling has been substantially
re-written (mostly by Eric Wong @normalperson in 44fc3d08).

These tests now in fact pass reliably on Ruby master on FreeBSD 13.2 and
OpenBSD 7.3. I stress-tested the test_wait_and_sigchild test on my
laptop by running four copies of the test in a loop on a 8-core VM; both
by itself and also as part of the whole test_process.rb file. I did not
see any failures.

Let's unskip the test and close [#4173] out. I'll keep an eye out on Ruby
CI for any flakes in this file on BSD after this gets merged, but if we
don't see any I'm going to assume 44fc3d08 or related changes around
that time accidently fixed this bug.

It's also probably important to unskip this test so that if another
attempt at removing the special SIGCHLD handling is made (like was
reverted in https://github.com/ruby/ruby/pull/7517), we get signal if
that breaks on FreeBSD/OpenBSD.

[Fixes #4173]
This commit is contained in:
KJ Tsanaktsidis 2023-05-15 14:37:28 +10:00 committed by GitHub
parent d9033d3749
commit 8bd4d8867a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
Notes: git 2023-05-15 04:37:48 +00:00 
Merged-By: ioquatix <samuel@codeotaku.com>
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/ruby/test_process.rb
View File

@ -1702,11 +1702,6 @@ class TestProcess < Test::Unit::TestCase
end end
def test_wait_and_sigchild def test_wait_and_sigchild
if /freebsd|openbsd/ =~ RUBY_PLATFORM
# this relates #4173
# When ruby can use 2 cores, signal and wait4 may miss the signal.
omit "this fails on FreeBSD and OpenBSD on multithreaded environment"
end
signal_received = [] signal_received = []
IO.pipe do |sig_r, sig_w| IO.pipe do |sig_r, sig_w|
Signal.trap(:CHLD) do Signal.trap(:CHLD) do