From 8a8618d4f3b35a5f114a3a5e05c80a7edb30546c Mon Sep 17 00:00:00 2001 From: Peter Zhu Date: Wed, 31 May 2023 09:57:33 -0400 Subject: [PATCH] Don't refetch ptr and len The call to RSTRING_GETMEM already fetched the pointer and length, so we don't need to fetch it again. --- string.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/string.c b/string.c index df1464fb70..aba5f47535 100644 --- a/string.c +++ b/string.c @@ -3057,13 +3057,9 @@ str_buf_cat4(VALUE str, const char *ptr, long len, bool keep_cr) if (STR_EMBED_P(str)) { capa = str_embed_capa(str) - termlen; - sptr = RSTRING(str)->as.embed.ary; - olen = RSTRING_EMBED_LEN(str); } else { capa = RSTRING(str)->as.heap.aux.capa; - sptr = RSTRING(str)->as.heap.ptr; - olen = RSTRING(str)->as.heap.len; } if (olen > LONG_MAX - len) { rb_raise(rb_eArgError, "string sizes too big");