1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ruby/prism] Revert "Properly destructure procarg0 in parser translation"

Browse Source 
This reverts commit https://github.com/ruby/prism/commit/823e931ff230.

https://github.com/ruby/prism/commit/d8ae19d033
This commit is contained in:
Kevin Newton 2024-06-03 17:29:39 -04:00 committed by git
parent 5502890a2f
commit 89ef1392f8
2 changed files with 19 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
lib/prism/translation/parser/compiler.rb
View File

@ -1390,12 +1390,12 @@ module Prism
if node.requireds.any?
node.requireds.each do |required|
params <<
if required.is_a?(RequiredParameterNode)
visit(required)
else
required.accept(copy_compiler(in_destructure: true))
end
if required.is_a?(RequiredParameterNode)
params << visit(required)
else
compiler = copy_compiler(in_destructure: true)
params << required.accept(compiler)
end
end
end
@ -1404,12 +1404,12 @@ module Prism
if node.posts.any?
node.posts.each do |post|
params <<
if post.is_a?(RequiredParameterNode)
visit(post)
else
post.accept(copy_compiler(in_destructure: true))
end
if post.is_a?(RequiredParameterNode)
params << visit(post)
else
compiler = copy_compiler(in_destructure: true)
params << post.accept(compiler)
end
end
end
@ -2004,8 +2004,7 @@ module Prism
token(parameters.opening_loc),
if procarg0?(parameters.parameters)
parameter = parameters.parameters.requireds.first
visited = parameter.is_a?(RequiredParameterNode) ? visit(parameter) : parameter.accept(copy_compiler(in_destructure: true))
[builder.procarg0(visited)].concat(visit_all(parameters.locals))
[builder.procarg0(visit(parameter))].concat(visit_all(parameters.locals))
else
visit(parameters)
end,

6
test/prism/ruby/parser_test.rb
View File

@ -52,6 +52,11 @@ module Prism
"spanning_heredoc.txt",
"spanning_heredoc_newlines.txt",
"unescaping.txt",
"seattlerb/block_decomp_anon_splat_arg.txt",
"seattlerb/block_decomp_arg_splat_arg.txt",
"seattlerb/block_decomp_arg_splat.txt",
"seattlerb/block_decomp_splat.txt",
"seattlerb/block_paren_splat.txt",
"seattlerb/bug190.txt",
"seattlerb/heredoc_nested.txt",
"seattlerb/heredoc_with_carriage_return_escapes_windows.txt",
@ -64,6 +69,7 @@ module Prism
"seattlerb/pctW_lineno.txt",
"seattlerb/regexp_esc_C_slash.txt",
"seattlerb/TestRubyParserShared.txt",
"unparser/corpus/literal/block.txt",
"unparser/corpus/literal/literal.txt",
"unparser/corpus/literal/pattern.txt",
"unparser/corpus/semantic/dstr.txt",