From 87988756d0ad0c494c7589d75a079207ce0747ee Mon Sep 17 00:00:00 2001 From: Stan Lo Date: Wed, 26 Oct 2022 15:44:01 +0100 Subject: [PATCH] [ruby/irb] Remove unnecessary warning check on help command It's not an intentional behavior of the command and it behaves differently in different environments. So checking it actually brings more problem than benefit. https://github.com/ruby/irb/commit/b3203bc784 --- test/irb/test_cmd.rb | 5 ----- 1 file changed, 5 deletions(-) diff --git a/test/irb/test_cmd.rb b/test/irb/test_cmd.rb index fa04b60f9f..662af94b81 100644 --- a/test/irb/test_cmd.rb +++ b/test/irb/test_cmd.rb @@ -388,9 +388,6 @@ module TestIRB irb.eval_input end - # the help command lazily loads rdoc by redefining the execute method - assert_match(/discarding old execute/, err) unless RUBY_ENGINE == 'truffleruby' - # the former is what we'd get without document content installed, like on CI # the latter is what we may get locally possible_rdoc_output = [/Nothing known about String#gsub/, /Returns a copy of self with all occurrences of the given pattern/] @@ -414,8 +411,6 @@ module TestIRB end end - # since LoadError will be raised, the execute won't be redefined - assert_no_match(/discarding old execute/, err) # if it fails to require rdoc, it only returns the command object assert_match(/=> IRB::ExtendCommand::Help\n/, out) ensure