1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "Add workaround for inserting into addr2insn mapping"

Browse Source 
This reverts commit 6b765b7ca0dad82ffbdeea76c63a0cac5fdc4bfd.
It made things much slower and didn't fix the crash.
This commit is contained in:
Alan Wu 2020-09-22 18:25:29 -04:00
parent 265c5ca8b1
commit 86c438d129
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ujit_compile.c
View File

@ -64,14 +64,7 @@ addr2insn_bookkeeping(void *code_ptr, int insn)
const void * const translated_address = table[insn];
st_data_t encoded_insn_data;
if (st_lookup(rb_encoded_insn_data, (st_data_t)translated_address, &encoded_insn_data)) {
// This is a roundabout way of doing an insert. Doing a plain insert can cause GC
// while inserting. While inserting, the table is in an inconsistent state and the
// GC can do a lookup in the table.
st_table *new_table = st_copy(rb_encoded_insn_data);
st_table *old_table = rb_encoded_insn_data;
st_insert(new_table, (st_data_t)code_ptr, encoded_insn_data);
rb_encoded_insn_data = new_table;
st_free_table(old_table);
st_insert(rb_encoded_insn_data, (st_data_t)code_ptr, encoded_insn_data);
}
else {
rb_bug("ujit: failed to find info for original instruction while dealing with addr2insn");