1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make ObjectSpace::WeakMap#[]= return Qnil

Browse Source 
Instead of returning some obscure value in ObjectSpace::WeakMap#[]= that's
not even useful, we can just simply return Qnil.
This commit is contained in:
Peter Zhu 2024-11-08 15:01:09 -05:00
parent 6a3eb384ce
commit 8672e88cd2
Notes: git 2024-11-11 18:38:56 +00:00 
Merged: https://github.com/ruby/ruby/pull/12037
1 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
weakmap.c
View File

@ -439,18 +439,6 @@ wmap_values(VALUE self)
return ary; return ary;
} }
static VALUE
nonspecial_obj_id(VALUE obj)
{
#if SIZEOF_LONG == SIZEOF_VOIDP
return (VALUE)((SIGNED_VALUE)(obj)|FIXNUM_FLAG);
#elif SIZEOF_LONG_LONG == SIZEOF_VOIDP
return LL2NUM((SIGNED_VALUE)(obj) / 2);
#else
# error not supported
#endif
}
static int static int
wmap_aset_replace(st_data_t *key, st_data_t *val, st_data_t new_key_ptr, int existing) wmap_aset_replace(st_data_t *key, st_data_t *val, st_data_t new_key_ptr, int existing)
{ {
@ -495,7 +483,7 @@ wmap_aset(VALUE self, VALUE key, VALUE val)
RB_OBJ_WRITTEN(self, Qundef, key); RB_OBJ_WRITTEN(self, Qundef, key);
RB_OBJ_WRITTEN(self, Qundef, val); RB_OBJ_WRITTEN(self, Qundef, val);
return nonspecial_obj_id(val); return Qnil;
} }
/* Retrieves a weakly referenced object with the given key */ /* Retrieves a weakly referenced object with the given key */