1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove temporary directory properly

Browse Source 
For each `make check`, rubygems test makes "tmp" directory and
some "gem_generate_index..." directories remain there.

* Do not create a (fixed name) directory in the current working
  directory
* Should remove its own temporary directory
This commit is contained in:
Nobuyoshi Nakada 2021-01-24 18:26:50 +09:00
parent 52ebaf718e
commit 80bad36989
Notes: git 2021-01-24 19:30:33 +09:00 
Merged: https://github.com/ruby/ruby/pull/4115
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/rubygems/test_case.rb
View File

@ -301,9 +301,6 @@ class Gem::TestCase < Minitest::Test
def setup def setup
@orig_env = ENV.to_hash @orig_env = ENV.to_hash
@tmp = File.expand_path("tmp")
FileUtils.mkdir_p @tmp
ENV['GEM_VENDOR'] = nil ENV['GEM_VENDOR'] = nil
ENV['GEMRC'] = nil ENV['GEMRC'] = nil
@ -312,7 +309,6 @@ class Gem::TestCase < Minitest::Test
ENV['XDG_DATA_HOME'] = nil ENV['XDG_DATA_HOME'] = nil
ENV['SOURCE_DATE_EPOCH'] = nil ENV['SOURCE_DATE_EPOCH'] = nil
ENV['BUNDLER_VERSION'] = nil ENV['BUNDLER_VERSION'] = nil
ENV["TMPDIR"] = @tmp
@current_dir = Dir.pwd @current_dir = Dir.pwd
@fetcher = nil @fetcher = nil
@ -323,13 +319,10 @@ class Gem::TestCase < Minitest::Test
# capture output # capture output
Gem::DefaultUserInteraction.ui = Gem::MockGemUi.new Gem::DefaultUserInteraction.ui = Gem::MockGemUi.new
tmpdir = File.realpath Dir.tmpdir tmpdir = File.realpath(Dir.mktmpdir("test_rubygems_"))
tmpdir.tap(&Gem::UNTAINT) tmpdir.tap(&Gem::UNTAINT)
ENV["TMPDIR"] = @tmp = File.dirname(tmpdir)
@tempdir = File.join(tmpdir, "test_rubygems_#{$$}") @tempdir = tmpdir
@tempdir.tap(&Gem::UNTAINT)
FileUtils.mkdir_p @tempdir
@orig_SYSTEM_WIDE_CONFIG_FILE = Gem::ConfigFile::SYSTEM_WIDE_CONFIG_FILE @orig_SYSTEM_WIDE_CONFIG_FILE = Gem::ConfigFile::SYSTEM_WIDE_CONFIG_FILE
Gem::ConfigFile.send :remove_const, :SYSTEM_WIDE_CONFIG_FILE Gem::ConfigFile.send :remove_const, :SYSTEM_WIDE_CONFIG_FILE