1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ruby/logger] Another performance improvement on the Formatter by

Browse Source 
using Kernel#sprintf over String#%
(https://github.com/ruby/logger/pull/75)

* Prefer Kernel#sprintf over String#% for formatting Strings
This commit is contained in:
Akira Matsuda 2022-12-08 12:31:30 +09:00 committed by git
parent 7ab4820af7
commit 7e121dc4a8
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/logger/formatter.rb
View File

@ -3,7 +3,7 @@
class Logger class Logger
# Default formatter for log messages. # Default formatter for log messages.
class Formatter class Formatter
Format = "%s, [%s #%d] %5s -- %s: %s\n" Format = "%.1s, [%s #%d] %5s -- %s: %s\n"
DatetimeFormat = "%Y-%m-%dT%H:%M:%S.%6N" DatetimeFormat = "%Y-%m-%dT%H:%M:%S.%6N"
attr_accessor :datetime_format attr_accessor :datetime_format
@ -13,8 +13,7 @@ class Logger
end end
def call(severity, time, progname, msg) def call(severity, time, progname, msg)
Format % [severity[0, 1], format_datetime(time), Process.pid, severity, progname, sprintf(Format, severity, format_datetime(time), Process.pid, severity, progname, msg2str(msg))
msg2str(msg)]
end end
private private