1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Stop pinning shape edges

Browse Source 
Now that `rb_shape_traverse_from_new_root` has been eliminated there's
no longer any reason to pin these objects, because we no longer
need to traverse shapes downward during compaction.
This commit is contained in:
Jean Boussier 2025-06-07 17:30:29 +02:00
parent a640723d31
commit 7d8695e02f
Notes: git 2025-06-07 16:30:57 +00:00 
Merged: https://github.com/ruby/ruby/pull/13556
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
shape.c
View File

@ -304,14 +304,7 @@ shape_tree_mark(void *data)
rb_shape_t *end = RSHAPE(GET_SHAPE_TREE()->next_shape_id - 1);
while (cursor < end) {
if (cursor->edges && !SINGLE_CHILD_P(cursor->edges)) {
// FIXME: GC compaction may call `rb_shape_traverse_from_new_root`
// to migrate objects from one object slot to another.
// Because of this if we don't pin `cursor->edges` it might be turned
// into a T_MOVED during GC.
// We'd need to eliminate `SHAPE_T_OBJECT` so that GC never need to lookup
// shapes this way.
// rb_gc_mark_movable(cursor->edges);
rb_gc_mark(cursor->edges);
rb_gc_mark_movable(cursor->edges);
}
cursor++;
}