1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Pool more slots for large size pools

Browse Source 
We always sweep at least 2048 slots per sweep step, but only pool one
page. For large size pools, 2048 slots is many pages but one page is
very few slots. This commit changes it so that at least 1024 slots are
placed in the pooled pages per sweep step.
This commit is contained in:
Peter Zhu 2023-08-18 09:56:46 -04:00
parent 790df7d383
commit 7a930cf0e4
Notes: git 2023-09-05 14:52:58 +00:00 
Merged: https://github.com/ruby/ruby/pull/8249
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gc.c
View File

@ -1233,6 +1233,7 @@ total_freed_objects(rb_objspace_t *objspace)
#define is_incremental_marking(objspace) ((objspace)->flags.during_incremental_marking != FALSE)
#define will_be_incremental_marking(objspace) ((objspace)->rgengc.need_major_gc != GPR_FLAG_NONE)
#define GC_INCREMENTAL_SWEEP_SLOT_COUNT 2048
#define GC_INCREMENTAL_SWEEP_POOL_SLOT_COUT 1024
#define is_lazy_sweeping(objspace) (GC_ENABLE_LAZY_SWEEP && has_sweeping_pages(objspace))
#if SIZEOF_LONG == SIZEOF_VOIDP
@ -5781,9 +5782,7 @@ gc_sweep_step(rb_objspace_t *objspace, rb_size_pool_t *size_pool, rb_heap_t *hea
struct heap_page *sweep_page = heap->sweeping_page;
int unlink_limit = GC_SWEEP_PAGES_FREEABLE_PER_STEP;
int swept_slots = 0;
bool need_pool = TRUE;
gc_report(2, objspace, "gc_sweep_step (need_pool: %d)\n", need_pool);
int pooled_slots = 0;
if (sweep_page == NULL) return FALSE;
@ -5818,9 +5817,9 @@ gc_sweep_step(rb_objspace_t *objspace, rb_size_pool_t *size_pool, rb_heap_t *hea
size_pool->freed_slots += ctx.freed_slots;
size_pool->empty_slots += ctx.empty_slots;
if (need_pool) {
if (pooled_slots < GC_INCREMENTAL_SWEEP_POOL_SLOT_COUT) {
heap_add_poolpage(objspace, heap, sweep_page);
need_pool = FALSE;
pooled_slots += free_slots;
}
else {
heap_add_freepage(heap, sweep_page);