1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Consider rb_str_getbyte as leaf sometimes

Browse Source 
If YJIT knows the parameter to rb_str_getbyte is a fixnum, then I think
we can consider the function to be a leaf
This commit is contained in:
Aaron Patterson 2024-02-14 11:49:10 -08:00 committed by Aaron Patterson
parent fadb7d412b
commit 7943cb22f6
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
yjit/src/codegen.rs
View File

@ -5395,11 +5395,18 @@ fn jit_rb_str_getbyte(
extern "C" { extern "C" {
fn rb_str_getbyte(str: VALUE, index: VALUE) -> VALUE; fn rb_str_getbyte(str: VALUE, index: VALUE) -> VALUE;
} }
// Raises when non-integers are passed in
jit_prepare_non_leaf_call(jit, asm);
let index = asm.stack_opnd(0); let index = asm.stack_opnd(0);
let recv = asm.stack_opnd(1); let recv = asm.stack_opnd(1);
let arg0_type = asm.ctx.get_opnd_type(index.into());
// rb_str_getbyte should be leaf if the index is a fixnum
if arg0_type != Type::Fixnum {
// Raises when non-integers are passed in
jit_prepare_non_leaf_call(jit, asm);
}
let ret_opnd = asm.ccall(rb_str_getbyte as *const u8, vec![recv, index]); let ret_opnd = asm.ccall(rb_str_getbyte as *const u8, vec![recv, index]);
asm.stack_pop(2); // Keep them on stack during ccall for GC asm.stack_pop(2); // Keep them on stack during ccall for GC