1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ruby/psych] issue #443: drop special tests for y, Y, n, N since they covered in the more general test

Browse Source 
https://github.com/ruby/psych/commit/6750b35402
This commit is contained in:
Colin Kelley 2023-07-19 13:14:10 -07:00 committed by git
parent 8ae24e6b08
commit 77593495f7
1 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
test/psych/test_string.rb
View File

@ -17,20 +17,11 @@ module Psych
end end
end end
# 'y' and 'n' are kind of ambiguous. Syck treated y and n literals in # 'y', 'Y', 'n', 'N' are kind of ambiguous. Syck treated those literals in
# YAML documents as strings. But this is not what the YAML 1.1 spec says. # YAML documents as strings. But this is not what the YAML 1.1 spec says.
# YAML 1.1 says they should be treated as booleans. When we're dumping # YAML 1.1 says they should be treated as booleans. When we're dumping
# documents, we know it's a string, so adding quotes will eliminate the # documents, we know it's a string, so adding quotes will eliminate the
# "ambiguity" in the emitted document # "ambiguity" in the emitted document
def test_y_is_quoted
assert_match(/"y"/, Psych.dump("y"))
assert_match(/"Y"/, Psych.dump("Y"))
end
def test_n_is_quoted
assert_match(/"n"/, Psych.dump("n"))
assert_match(/"N"/, Psych.dump("N"))
end
def test_all_yaml_1_1_booleans_are_quoted def test_all_yaml_1_1_booleans_are_quoted
yaml_1_1_booleans = %w[y Y yes Yes YES n N no No NO true True TRUE false False FALSE on On ON off Off OFF] # from https://yaml.org/type/bool.html yaml_1_1_booleans = %w[y Y yes Yes YES n N no No NO true True TRUE false False FALSE on On ON off Off OFF] # from https://yaml.org/type/bool.html