1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ruby/irb] Fixed string escaping omissions

Browse Source 
(https://github.com/ruby/irb/pull/599)

I received a `RegexpError` when I typed `::Array[`.
::Array[/Users/mi/ghq/github.com/ruby/irb/lib/irb/completion.rb:236:in `retrieve_completion_data': premature end of char-class: /^Array[/ (RegexpError)
This commit is contained in:
ima1zumi 2023-06-06 03:34:05 +09:00 committed by git
parent 135a5eb716
commit 76ee4edb97
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/irb/completion.rb
View File

@ -233,7 +233,7 @@ module IRB
if doc_namespace if doc_namespace
candidates.find { |i| i == receiver } candidates.find { |i| i == receiver }
else else
candidates.grep(/^#{receiver}/).collect{|e| "::" + e} candidates.grep(/^#{Regexp.quote(receiver)}/).collect{|e| "::" + e}
end end
when /^([A-Z].*)::([^:.]*)$/ when /^([A-Z].*)::([^:.]*)$/

1
test/irb/test_completion.rb
View File

@ -310,6 +310,7 @@ module TestIRB
assert_empty(IRB::InputCompletor.retrieve_completion_data("::A.", bind: binding)) assert_empty(IRB::InputCompletor.retrieve_completion_data("::A.", bind: binding))
assert_empty(IRB::InputCompletor.retrieve_completion_data("::A(", bind: binding)) assert_empty(IRB::InputCompletor.retrieve_completion_data("::A(", bind: binding))
assert_empty(IRB::InputCompletor.retrieve_completion_data("::A)", bind: binding)) assert_empty(IRB::InputCompletor.retrieve_completion_data("::A)", bind: binding))
assert_empty(IRB::InputCompletor.retrieve_completion_data("::A[", bind: binding))
end end
def test_complete_reserved_words def test_complete_reserved_words