1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Module#ancestors should not return superclasses of refinements

Browse Source 
[ruby-core:86949] [Bug #14744]

Reported by Eregon (Benoit Daloze).  Thanks!
This commit is contained in:
Shugo Maeda 2021-08-20 10:42:01 +09:00
parent 70510d1545
commit 754adbee91
No known key found for this signature in database
GPG Key ID: 2DFE34085E97CE47
2 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
class.c
View File

@ -1347,8 +1347,13 @@ VALUE
rb_mod_ancestors(VALUE mod) rb_mod_ancestors(VALUE mod)
{ {
VALUE p, ary = rb_ary_new(); VALUE p, ary = rb_ary_new();
VALUE refined_class = Qnil;
if (FL_TEST(mod, RMODULE_IS_REFINEMENT)) {
refined_class = rb_refinement_module_get_refined_class(mod);
}
for (p = mod; p; p = RCLASS_SUPER(p)) { for (p = mod; p; p = RCLASS_SUPER(p)) {
if (p == refined_class) break;
if (p != RCLASS_ORIGIN(p)) continue; if (p != RCLASS_ORIGIN(p)) continue;
if (BUILTIN_TYPE(p) == T_ICLASS) { if (BUILTIN_TYPE(p) == T_ICLASS) {
rb_ary_push(ary, RBASIC(p)->klass); rb_ary_push(ary, RBASIC(p)->klass);

12
test/ruby/test_refinement.rb
View File

@ -2559,6 +2559,18 @@ class TestRefinement < Test::Unit::TestCase
assert_equal(:refined, Bug17822::Client.call_foo) assert_equal(:refined, Bug17822::Client.call_foo)
end end
def test_ancestors
refinement = nil
as = nil
Module.new do
refine Array do
refinement = self
as = ancestors
end
end
assert_equal([refinement], as, "[ruby-core:86949] [Bug #14744]")
end
private private
def eval_using(mod, s) def eval_using(mod, s)